Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libdispatch package #44773

Closed
wants to merge 1 commit into from
Closed

Libdispatch package #44773

wants to merge 1 commit into from

Conversation

Ilia1
Copy link

@Ilia1 Ilia1 commented Jul 1, 2023

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, x86-64

This library is required to upgrade package deadbeef.

@Bnyro
Copy link
Contributor

Bnyro commented Jul 1, 2023

This should likely be in the same PR with the deadbeef update. And please do one commit per added / updated package as explained in https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#updating-a-template.

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jul 1, 2023
@Ilia1
Copy link
Author

Ilia1 commented Jul 2, 2023

This library is not specific to the deadbeef package and can be used by other programs in the future. So I put it in a separate package.

@Bnyro
Copy link
Contributor

Bnyro commented Jul 2, 2023

Yes, but your other PR depends on it. So it should be added in the same PR as a dependency, because it's required there in order to update the package.
Nevertheless the package has to be independent from the deadbeef package.

@Ilia1
Copy link
Author

Ilia1 commented Jul 2, 2023

OK, I was thinking that 1 PR = 1 package.
Now I close this PR.

@Ilia1 Ilia1 closed this Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants