Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail2ban: update to 1.0.2 #44787

Merged
merged 1 commit into from Jul 4, 2023
Merged

Conversation

MeganerdNL
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • armv6l-glibc

Why this was necessary

There are many changes in fail2ban recently, especially for Python 3.11 - which is standard Python 3 in Void Linux now. Solves some compile errors in often used jail configs.

@necrophcodr
Copy link
Contributor

@@ -2,4 +2,4 @@
exec 2>&1
mkdir -p /var/run/fail2ban

exec fail2ban-server -f
exec fail2ban-server -f >/dev/null 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware that this may drop any errors or logging output happening from the server.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this change?

Copy link
Contributor Author

@MeganerdNL MeganerdNL Jul 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this change?

It prevents the spamming the local login with messages every time you change something (Server OK and so on). I can remove it so users can add it themselves if it has other unwanted effects I'm not aware of.

@MeganerdNL
Copy link
Contributor Author

@MeganerdNL You may want to read https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes on how to format commits.

Thanks. Sorry, I did read it, but thought using git only was ok too.
If it's a requirement I will use it from now on.

@Bnyro
Copy link
Contributor

Bnyro commented Jul 2, 2023

Following the proper commit message style is a requirement for the PR to become merged.
You can run git commit --amend -m "fail2ban: update to 1.0.2. and git push -f to fix the commit message.

@MeganerdNL
Copy link
Contributor Author

  • I removed ">/dev/null 2>&1" in the run command as it could indeed prevent important messages per @necrophcodr / @mhmdanas
  • I corrected the commit message style as required per @Bnyro.

@MeganerdNL MeganerdNL changed the title Update fail2ban to newest stable fail2ban: update to 1.0.2 Jul 2, 2023
@Bnyro
Copy link
Contributor

Bnyro commented Jul 2, 2023

Please run git rebase -i master instead of merging the changes.

@MeganerdNL
Copy link
Contributor Author

Please run git rebase -i master instead of merging the changes.

Yes I will in the future. Relatively new to git and github. Quick learner. Let me know if I have to change anything now - it seems not,. Cheers.

@Bnyro
Copy link
Contributor

Bnyro commented Jul 2, 2023

Yes, you should fix that now because your PR now contains 2 useless commits where you merged with the latest master changes. Otherwise your PR can't be merged because it destroys the commit history.

@MeganerdNL
Copy link
Contributor Author

Yes, you should fix that now because your PR now contains 2 useless commits where you merged with the latest master changes. Otherwise your PR can't be merged because it destroys the commit history.

I did what you said. But it complained. Then I forced pushed it. Is it oke now? Only 1 commit... so it seems. Really sorry for the trouble. Thanks for the help.

@Bnyro
Copy link
Contributor

Bnyro commented Jul 2, 2023

Yes, the changes in the PR looks good to me now!
Didn't test the package though.

@MeganerdNL
Copy link
Contributor Author

Ok. last force-push unnecessary. Nothing happened. Learned something.

@Duncaen Duncaen merged commit 0272355 into void-linux:master Jul 4, 2023
8 checks passed
@MeganerdNL MeganerdNL deleted the fail2ban-update branch July 5, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants