New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fail2ban: update to 1.0.2 #44787
fail2ban: update to 1.0.2 #44787
Conversation
@MeganerdNL You may want to read https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes on how to format commits. |
srcpkgs/fail2ban/files/fail2ban/run
Outdated
@@ -2,4 +2,4 @@ | |||
exec 2>&1 | |||
mkdir -p /var/run/fail2ban | |||
|
|||
exec fail2ban-server -f | |||
exec fail2ban-server -f >/dev/null 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be aware that this may drop any errors or logging output happening from the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of this change?
It prevents the spamming the local login with messages every time you change something (Server OK and so on). I can remove it so users can add it themselves if it has other unwanted effects I'm not aware of.
Thanks. Sorry, I did read it, but thought using git only was ok too. |
Following the proper commit message style is a requirement for the PR to become merged. |
f381333
to
d577f4e
Compare
|
Please run |
Yes I will in the future. Relatively new to git and github. Quick learner. Let me know if I have to change anything now - it seems not,. Cheers. |
Yes, you should fix that now because your PR now contains 2 useless commits where you merged with the latest master changes. Otherwise your PR can't be merged because it destroys the commit history. |
ff74880
to
ebd15da
Compare
I did what you said. But it complained. Then I forced pushed it. Is it oke now? Only 1 commit... so it seems. Really sorry for the trouble. Thanks for the help. |
Yes, the changes in the PR looks good to me now! |
ebd15da
to
870633e
Compare
Ok. last force-push unnecessary. Nothing happened. Learned something. |
Testing the changes
Local build testing
Why this was necessary
There are many changes in fail2ban recently, especially for Python 3.11 - which is standard Python 3 in Void Linux now. Solves some compile errors in often used jail configs.