New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add step to verify the functionality of update-check #44927
Conversation
Not against, but if package got updated, it means somebody tracks updates. It may be more fruitful to report |
7ce8a8c
to
4bc6e68
Compare
If we report
also, this could let reviewers check if there are further updates available |
26cd2c8
to
3118be7
Compare
I didn't knew about _log.txt, thanks. Shouldn't this go into lint job rather than x86_64 build? Ack overall for checking new packages. |
2a87dc7
to
cc5bdaf
Compare
this is out of convenience, because the lint job does not run in a void container but instead on the ubuntu host. I've attempted to bring it over to a void container like the build CI but xlint was doing something weird with the escaping of backreferences in a sed. it works as-is but in void it does not resolve the backreference properly (see here) |
b08fe88
to
49dbfdf
Compare
49dbfdf
to
c85e2af
Compare
c85e2af
to
49ac3e8
Compare
…heck useful for cases where update checking does not make sense or is impossible
dd5a745
to
362cad7
Compare
ok this now runs the update-check lint in the lint job, now that xlint can run with bash as sh (thanks btw!) example here: https://github.com/void-linux/void-packages/actions/runs/6091407376/job/16527947208?pr=44927 |
362cad7
to
bbe2c9d
Compare
runs update-check on all changed templates, then errors only if there was an issue with the update-check. does not error if further updates are available, as there may be a good reason not to update to those versions
example output:
Testing the changes