Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add step to verify the functionality of update-check #44927

Merged
merged 4 commits into from Sep 8, 2023

Conversation

classabbyamp
Copy link
Member

@classabbyamp classabbyamp commented Jul 8, 2023

runs update-check on all changed templates, then errors only if there was an issue with the update-check. does not error if further updates are available, as there may be a good reason not to update to those versions

example output:
image

Testing the changes

  • I tested the changes in this PR: YES

@Chocimier
Copy link
Member

Not against, but if package got updated, it means somebody tracks updates.

It may be more fruitful to report NO VERSION found for in void-updates.

@classabbyamp
Copy link
Member Author

If we report NO VERSION found here while a package is being updated, then it can be fixed (or, as of now, disabled) while the package is being updated.

NO VERSION found is also reported in https://repo-default.voidlinux.org/void-updates/void-updates/_log.txt already but that's kinda hidden.

also, this could let reviewers check if there are further updates available

@classabbyamp classabbyamp force-pushed the update-check-ci branch 4 times, most recently from 26cd2c8 to 3118be7 Compare July 8, 2023 20:45
@Chocimier
Copy link
Member

I didn't knew about _log.txt, thanks.

Shouldn't this go into lint job rather than x86_64 build?

Ack overall for checking new packages.

@classabbyamp classabbyamp force-pushed the update-check-ci branch 2 times, most recently from 2a87dc7 to cc5bdaf Compare July 8, 2023 21:01
@classabbyamp
Copy link
Member Author

Shouldn't this go into lint job rather than x86_64 build?

this is out of convenience, because the lint job does not run in a void container but instead on the ubuntu host. I've attempted to bring it over to a void container like the build CI but xlint was doing something weird with the escaping of backreferences in a sed. it works as-is but in void it does not resolve the backreference properly (see here)

.github/workflows/build.yaml Outdated Show resolved Hide resolved
@classabbyamp classabbyamp force-pushed the update-check-ci branch 2 times, most recently from b08fe88 to 49dbfdf Compare July 8, 2023 23:02
@classabbyamp classabbyamp added the xbps-src xbps-src related label Jul 8, 2023
@classabbyamp
Copy link
Member Author

ok this now runs the update-check lint in the lint job, now that xlint can run with bash as sh (thanks btw!)

example here: https://github.com/void-linux/void-packages/actions/runs/6091407376/job/16527947208?pr=44927

@classabbyamp classabbyamp merged commit 95ed99c into void-linux:master Sep 8, 2023
@classabbyamp classabbyamp deleted the update-check-ci branch September 8, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
xbps-src xbps-src related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants