-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mandrel: update to 23.0.1.2; update revdeps #45056
Conversation
I'm not sure the patch is necessary. The source file it patched was completely removed with it's parent dir. Found some similar code at |
The patch is needed if it links musl statically else (easy to verify). Please also rebuild Babashka. |
Does that require a musl system to verify? |
We want this dynamically linked. |
d4c3c07
to
c485f2e
Compare
Something is wrong, bb and jet are still static binaries on x86_64-musl. |
I'm a bit stumped. There's a
|
Hmm, looks like the linker doesn't get passed |
You need to patch /mandrel-mandrel-23.0.0.0-Final/substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/c/libc/HostedMuslLibC.java |
ugh, I just now saw the TEXTREL comment there -.- perhaps we actually wanna static link. sorry. |
Indeed, bb builds fine as PIE executable but segfaults on startup with musl. So let's scrap that, sorry for the distraction. |
Then this is good to go, I think! |
Do you want me to remove the |
Okay, but please keep the line that non-static is broken on musl. |
Testing the changes
jet
, included in PR)Local build testing
cc @leahneukirchen