Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: monophony-2.10.0 and dependency #45416

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Bnyro
Copy link
Contributor

@Bnyro Bnyro commented Aug 4, 2023

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures:
    • i686

@classabbyamp classabbyamp added the new-package This PR adds a new package label Aug 4, 2023
@Bnyro Bnyro force-pushed the monophony branch 2 times, most recently from 6aa14d7 to 6e427ba Compare August 16, 2023 14:41
@Bnyro Bnyro changed the title New package: monophony-1.10.0 and dependencies New package: monophony-2.0.0 and dependencies Aug 16, 2023
@Bnyro Bnyro force-pushed the monophony branch 2 times, most recently from 8f69053 to 9ec670a Compare August 16, 2023 17:40
@Bnyro Bnyro changed the title New package: monophony-2.0.0 and dependencies New package: monophony-2.0.1 and dependencies Aug 24, 2023
@Bnyro Bnyro changed the title New package: monophony-2.0.1 and dependencies New package: monophony-2.1.0 and dependencies Sep 10, 2023
@Bnyro Bnyro changed the title New package: monophony-2.1.0 and dependencies New package: monophony-2.2.0 and dependencies Sep 19, 2023
srcpkgs/monophony/template Outdated Show resolved Hide resolved
@Bnyro Bnyro force-pushed the monophony branch 2 times, most recently from 8095e5c to 0e8f65e Compare September 20, 2023 08:29
@Bnyro Bnyro force-pushed the monophony branch 2 times, most recently from a413606 to 253d69d Compare October 5, 2023 19:08
@Bnyro Bnyro changed the title New package: monophony-2.2.0 and dependencies New package: monophony-2.2.2 and dependencies Oct 5, 2023
@Bnyro
Copy link
Contributor Author

Bnyro commented Oct 31, 2023

Hey @zehkira, what's the state of Python3.12 for Monophony?

When compiling, I get

Nuitka-Reports:INFO: Compilation report written to file 'nuitka-crash-report.xml'.
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/nuitka/__main__.py", line 155, in <module>
    main()
  File "/usr/lib/python3.12/site-packages/nuitka/__main__.py", line 141, in main
    MainControl.main()
  File "/usr/lib/python3.12/site-packages/nuitka/MainControl.py", line 1093, in main
    _main()
  File "/usr/lib/python3.12/site-packages/nuitka/MainControl.py", line 962, in _main
    result, options = compileTree()
                      ^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/MainControl.py", line 836, in compileTree
    makeSourceDirectory()
  File "/usr/lib/python3.12/site-packages/nuitka/MainControl.py", line 437, in makeSourceDirectory
    source_code = CodeGeneration.generateModuleCode(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeGeneration.py", line 578, in generateModuleCode
    return _generateModuleCode(module=module, data_filename=data_filename)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeGeneration.py", line 538, in _generateModuleCode
    function_code, function_decl = generateFunctionBodyCode(
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeGeneration.py", line 482, in generateFunctionBodyCode
    function_code = getFunctionCode(
                    ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/FunctionCodes.py", line 612, in getFunctionCode
    return _getFunctionCode(
           ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/FunctionCodes.py", line 652, in _getFunctionCode
    generateStatementSequenceCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeHelpers.py", line 241, in generateStatementSequenceCode
    _generateStatementSequenceCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeHelpers.py", line 230, in _generateStatementSequenceCode
    generateStatementCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeHelpers.py", line 190, in generateStatementCode
    statement_dispatch_dict[statement.kind](
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/TryCodes.py", line 86, in generateTryCode
    generateStatementSequenceCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeHelpers.py", line 241, in generateStatementSequenceCode
    _generateStatementSequenceCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeHelpers.py", line 225, in _generateStatementSequenceCode
    generateStatementsFrameCode(
    getFrameGuardHeavyCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/FrameCodes.py", line 311, in getFrameGuardHeavyCode
    renderTemplateFromString(
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Jinja2.py", line 140, in renderTemplateFromString
    _template_cache[template_str] = getTemplateFromString(template_str)
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Jinja2.py", line 129, in getTemplateFromString
    return getEnvironment(
           ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Jinja2.py", line 77, in getEnvironment
    jinja2 = getJinja2Package()
             ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Jinja2.py", line 62, in getJinja2Package
    _loaded_pkg_resources = importFromInlineCopy("pkg_resources", must_exist=False)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Importing.py", line 184, in importFromInlineCopy
    return _importFromFolder(
           ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Importing.py", line 147, in _importFromFolder
    return __import__(module_name, level=0)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/build/inline_copy/pkg_resources/pkg_resources/__init__.py", line 2191, in <module>
    register_finder(pkgutil.ImpImporter, find_on_path)
                    ^^^^^^^^^^^^^^^^^^^
AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?

@zehkira
Copy link

zehkira commented Oct 31, 2023

Nuitka does not support Python 3.12 yet.

@Bnyro
Copy link
Contributor Author

Bnyro commented Oct 31, 2023

I assume there's no way to use monophony without compiling via Nuitka currently? It would be handy if it could be installed like any other Python module instead of being compiled first.

@zehkira
Copy link

zehkira commented Oct 31, 2023

You could patch the Makefile and the pyproject.toml to install it as a module. I don't recommend doing that though.

@Bnyro Bnyro marked this pull request as draft October 31, 2023 19:43
@Bnyro
Copy link
Contributor Author

Bnyro commented Oct 31, 2023

Okay, we'll wait for Nuitka to support Py3.12 then. Thanks for the answers!

@ahesford
Copy link
Member

As discussed in #47982, nuitka does not appear to be suitable for packaging on Void.

@Bnyro
Copy link
Contributor Author

Bnyro commented Jan 17, 2024

Closing for the given reasons.

@Bnyro Bnyro closed this Jan 17, 2024
@Bnyro Bnyro deleted the monophony branch January 17, 2024 18:37
@zehkira
Copy link

zehkira commented May 11, 2024

Starting with the upcoming v2.10.0 release, Monophony will no longer use Nuitka.

@Bnyro
Copy link
Contributor Author

Bnyro commented May 11, 2024

That's awesome, I'll give this PR an other shot once it's released 🚀

@Bnyro Bnyro restored the monophony branch May 13, 2024 11:45
@Bnyro Bnyro reopened this May 13, 2024
@Bnyro Bnyro changed the title New package: monophony-2.2.2 and dependencies New package: monophony-2.10.0 and dependencies May 13, 2024
@Bnyro Bnyro marked this pull request as ready for review May 13, 2024 11:56
@Bnyro Bnyro changed the title New package: monophony-2.10.0 and dependencies New package: monophony-2.10.0 and dependency May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants