Manual.md: make section concerning quoting version and pkgname clearer #45603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, it's worth to fix. Can be worded even even simpler, eg. "pkgname and version are forbidden to contain special characters. As such, they don't need to be quoted, and convention is to not quote." |
Bnyro
force-pushed
the
dont-quote-pkgname-and-version
branch
2 times, most recently
from
425c478
to
b15eda9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current description might be a bit difficult to understand for new contributors due to some grammatical things that could result in it to be understood in the wrong way.
[...] which make it necessary to quote themsomewhat could be interpreted that you actually should quote them.The rest are just minor grammar changes.