New package: sayonara-player-1.7.0.stable3

[fanyx]

Testing the changes

• I tested the changes in this PR: YES

New package

• This new package conforms to the package requirements: YES

[fanyx]

custom variables are supposed to be prefixed with _

sayonara-player:5: version must not contain the characters - or : or _
xlint cannot deal with that unfortunately...

[ahesford]

The version variable should never contain variables to expand; literal strings only. You can use something like version=1.7.0.stable3 and, in the distfiles, use ${version/.stable/-stable}.

[fanyx]

thanks, sounds good

[fanyx]

the build has been building openssl and other stuff alongside the actual program
any idea why that is?
the branch is rebased on current master

[ahesford]

With the change in version, the commit message should now read

New package: sayonara-player-1.7.0.stable3

Your checks are rebuilding a bunch of dependencies because we are in the middle of a massive OpenSSL update.

No longer applies

[fanyx]

Bumped to rerun checks

[fanyx]

@ahesford should i move the qt5- packages to hostmakedepends?
non-x86(_64) builds seem to be failing to this

[ahesford]

@ahesford should i move the qt5- packages to hostmakedepends? non-x86(_64) builds seem to be failing to this

No, you need qt5-host-tools in hostmakedepends for cross-builds. See the VLC template for an example.

[fanyx]

do i add

if [ "$XBPS_TARGET_LIBC" -eq "musl"]; then
    makedepends+=" libexecinfo"
fi

for musl builds?

[ahesford]

do i add

if [ "$XBPS_TARGET_LIBC" -eq "musl"]; then
    makedepends+=" libexecinfo"
fi

for musl builds?

It would be if [ "$XBPS_TARGET_LIBC" = "musl"]; (not -eq, which will attempt an integer comparison), but you're right that libexecinfo should be made available for musl builds.

[fanyx]

oh, i thought -eq and = were equal.
well, today i learned

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.