Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/cycles.yaml: run on PRs, don't run on forks #45933

Closed
wants to merge 10 commits into from

Conversation

classabbyamp
Copy link
Member

  • running on forks is kinda useless and just gives people useless error messages if they sync their master branch at the wrong time
  • run cycle check on PRs to catch cycles before they happen. this makes the cron cycle check more of a backup/just-in-case for things that slip past the CI

Testing the changes

  • I tested the changes in this PR: YES|briefly|NO

@classabbyamp classabbyamp force-pushed the ci/cycle-lint branch 2 times, most recently from 6b286d8 to 0f76076 Compare September 6, 2023 03:13
@classabbyamp
Copy link
Member Author

seems like running the cache save/restore actions in the container within ci isn't supported: actions/runner#2115

@classabbyamp classabbyamp marked this pull request as draft September 6, 2023 03:16
@classabbyamp classabbyamp marked this pull request as ready for review September 7, 2023 16:08
@classabbyamp classabbyamp marked this pull request as draft September 7, 2023 16:08
by storing the hash of the template in the cache, the cache can be invalidated
when the template is changed.
- running on forks is kinda useless and just gives people useless error
  messages if they sync their master branch at the wrong time
- run cycle check on PRs to catch cycles before they happen. this makes
  the cron cycle check more of a backup/just-in-case for things that
  slip past the CI
- speed things up by caching dependencies in github's cache
  functionality. this is only written by the scheduled job, not PRs.
@Chocimier
Copy link
Member

Merging common/, etc/, xbps-src in should clear and rebuild cache.

Copy link

github-actions bot commented Dec 7, 2023

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants