Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: stegseek-0.6 #45998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yoshiyoshyosh
Copy link
Contributor

@yoshiyoshyosh yoshiyoshyosh commented Sep 9, 2023

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • x86_64-musl
  • i686

@classabbyamp classabbyamp added the new-package This PR adds a new package label Sep 9, 2023
@yoshiyoshyosh
Copy link
Contributor Author

yoshiyoshyosh commented Sep 9, 2023

musl builds are failing cuz of mhash, looking into it. seems to be something not specific to this program and related to this possibly?. I doubt this could be patched around in any way
32 bit builds are failing cuz it tries to cap an unsigned long by comparing it with incompatible 1L (I think). this can probably be fixed with a vsed or patch. should I try to?

@yoshiyoshyosh yoshiyoshyosh marked this pull request as draft September 9, 2023 21:19
@yoshiyoshyosh
Copy link
Contributor Author

fixed the 32bit builds by incorporating this commit as a patch, but the musl builds will still fail without a patch to mhash. this is only a problem for C++ code that includes mhash and uses anything with its _Bools, which seems to be only this program.

@yoshiyoshyosh
Copy link
Contributor Author

I'll update this PR and un-draft it when #46005 lands. should fix all the build issues.

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Dec 10, 2023
@yoshiyoshyosh
Copy link
Contributor Author

still relevant

@github-actions github-actions bot removed the Stale label Dec 11, 2023
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 11, 2024
@yoshiyoshyosh
Copy link
Contributor Author

stiiiiil relevant :v

@github-actions github-actions bot removed the Stale label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants