Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3status-rust: update to 0.32.2. #46079

Closed
wants to merge 1 commit into from

Conversation

pablomancera
Copy link

@pablomancera pablomancera commented Sep 16, 2023

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64 (crossbuild)
    • aarch64 (local)
    • armv6l (crossbuild)

Supersedes #44899

@Duncaen
Copy link
Member

Duncaen commented Sep 22, 2023

Why is generating man pages a build option?

@pablomancera
Copy link
Author

Why is generating man pages a build option?

Because it uses pandoc to generate them, so some architectures won't be able to build the package if they also have to generate the man pages.

@Duncaen
Copy link
Member

Duncaen commented Sep 22, 2023

But its enabled by default effectively removing the package for the architectures we cross compile pacakges for.
This should be set if cross compiling, but not sure if a build option is really required here, you could just add pandoc to hostmakedepends if not cross compiling.

Edit: I guess the only benefit of keeping it a build optiona would be if someone natively builds pandoc and then cross compiles i3status-rust and wants to enable building the man pages.

@pablomancera
Copy link
Author

The idea of the line

env -i bash -c "source /etc/profile && cargo xtask generate-manpage"

is that the void build servers (which I think are x86_64) generates the man page using the packages native to their architecture and bundle them in the package for every other architecture. It's the solution I came up with after the review I got at #44899 so every architecture can get the man pages. I'm not entirely sure it's the best though, but it worked in my tests (local building for x86_64 and cross building for aarch64). If there is a better way of doing this I would like to hear it.

On the other hand, if anyone wants to build the package on an architecture limited by the pandoc package, they can disable the docs build option and it'll be fine.

That's the reason I added a docs build option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants