Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PYO3_CROSS_* in rust build-helper #46086

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Refactor PYO3_CROSS_* in rust build-helper #46086

merged 4 commits into from
Sep 26, 2023

Conversation

tornaria
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

@tornaria tornaria mentioned this pull request Sep 16, 2023
Merged
@classabbyamp classabbyamp added the xbps-src xbps-src related label Sep 16, 2023
@ahesford
Copy link
Member

ahesford commented Sep 26, 2023 •
edited
Loading

Can you rebase this and make the commit messages a bit more descriptive, like "inherit PYO3_CROSS variables from rust helper"?

@tornaria
Copy link
Contributor Author

Can you rebase this and make the commit messages a bit more descriptive, like "inherit PYO3_CROSS variables from rust helper"?

done

@ahesford ahesford merged commit 7113642 into void-linux:master Sep 26, 2023
5 of 8 checks passed
@tornaria tornaria deleted the pyo3-refactor branch September 26, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
xbps-src xbps-src related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tornaria @ahesford @classabbyamp