Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-package: ttf-nerd-fonts-symbols-3.0.2 #46118

Closed

Conversation

chrysos349
Copy link
Contributor

@cinerea0

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64

WHY?
nerd-fonts is a bloated package (2GB, REALLY?) which includes a ton of fonts, and scripts which can't be even executed by a non-root user due to permissions. BTW, these scripts have nothing to do with patching fonts, but with cheat sheet functionality. I don't even understand how it it was allowed into the repository in the first place!

ttf-nerd-fonts-symbols is the only part that's truly necessary. It provides unique glyphs. My template includes also fontconfig preset.

@classabbyamp
Copy link
Member

classabbyamp commented Sep 18, 2023

  1. will this break things people who use these fonts by name?
  2. it would make more sense for the old nerd fonts packages to be transitional dummy subpackages (grep for transitional in srcpkgs for examples) so that people don't get the fonts uninstalled

@classabbyamp classabbyamp added the new-package This PR adds a new package label Sep 18, 2023
@chrysos349
Copy link
Contributor Author

@classabbyamp good idea! working on it.

@chrysos349 chrysos349 changed the title New-package: ttf-nerd-fonts-symbols-3.0.2, removed-packages: revbump due to nerd-fonts{,-ttf,-otf} removal New-package: ttf-nerd-fonts-symbols-3.0.2 Sep 18, 2023
@chrysos349
Copy link
Contributor Author

@classabbyamp done!

@cinerea0
Copy link
Contributor

This is a bad idea:

  1. This completely removes the OTF fonts.
  2. There are 17 font families that are only packaged as their nerd-font patched variants. This change would remove them from users systems with no alternative except to manually install them.
  3. This breaks things for people who use the fonts by their full name.
  4. Even in situations where the "base" font is separately available, it doesn't seem to fallback properly.

@chrysos349
Copy link
Contributor Author

chrysos349 commented Sep 18, 2023

I included INSTALL.msg to the affected packages to explain the change.

@cinerea0

This is a bad idea:

making this bloated package a part of the official repo WAS a bad idea. replacing it with a leaner version which includes only unique glyphs (as per package requirements concerning fonts) IS NOT!

1. This completely removes the OTF fonts.

so what? the fonts can be downloaded manually.

2. There are 17 font families that are only packaged as their nerd-font patched variants.

do you mean the fonts with included nerd symbols and changed names? it doesn't matter. again, they fonts can be downloaded manually.

2. This change would remove them from users systems with no alternative except to manually install them.

the previous commits would. this one would leave all the fonts in /usr/share/fonts/NerdFonts, thanks to @classabbyamp 's suggestion.

3. This breaks things for people who use the fonts by their full name.

again, it won't. the only change is the fonts won't be updated anymore. they'll be left intact in the system dir.

4. Even in situations where the "base" font is separately available, it doesn't seem to fallback properly.

people can download the full versions of fonts themselves.

@ahesford
Copy link
Member

Whether you consider the addition of nerd-fonts to the repo a bad idea is irrelevant, because it is not your decision. We will not accept a PR that removes well-maintained packages from the distribution when the maintainer of those packages objects. Furthermore, you can avoid downloading the large font package and "download the [reduced] versions of fonts [yourself]" if you like.

If your PR offers some additional fonts that are not already present in the nerd-fonts packages, please separate the useful additions from the proposed removal and replacement. Otherwise, the PR is not suitable for merging.

@chrysos349 chrysos349 closed this Sep 19, 2023
@chrysos349 chrysos349 deleted the ttf-nerd-fonts-symbols branch January 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants