-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meson awareness to numpy
helper and python3-pep517
style
#46186
Conversation
9bfb2b4
to
865bce1
Compare
LGTM, do you want to cleanup A (very) minor nitpick: maybe But the idiom is used all over the place and currently there is no conflict possible. |
Adding spaces might thwart a match when the variable embeds a newline, like
which probably never ought to happen, but could cause hard-to-discover issues when it does. What we really need is to turn these space-separated variables into proper arrays so that we can test for membership the right way. Thanks for reminding me about pylint; I'll add a fix here. |
You may want to cherry-pick 0a2141b from #46109, to further cleanup the scipy template (no need for the pybind11 thing). I wonder about this:
Is this necessary? I didn't add this to |
Aha, it probably refers to the |
The python3 build helper is automatically pulled in by the python3 build styles. I haven't tested whether it can be removed now, but it was definitely needed when it was added. |
Closed in 0fcff10 with some additional changes:
|
Now that a
meson
build helper exists, we can further remove redundancy in some numeric python packages. In addition to the two cleaned up here, I believe we have some pending PRs that would benefit from these changes.While I'm touching the
numpy
helper, I might as well fix its missing documentation.cc: @tornaria
Testing the changes