Update Nim packages #46187
Closed
Update Nim packages #46187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updating choosenim fixed #46168. And while I was at it I also updated the Nim package itself. According to the Nim creator 2.0 is backwards compatible with at the source code level 1.x, so it should be fine to update the existing package instead of creating a new |
HiPhish
force-pushed
the
nim
branch
2 times, most recently
from
b0c0450
to
07da620
Compare
|
@SolitudeSF Can you please review my choosenim update? I have removed the patch because everything seems to be working fine without it. |
|
Looks like someone already beat me to Nim 2.0, so I am closing this PR. I will open a new one for Choosenim only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing