[RFC] do not install checkdepends when check is not going to run #46207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pends when check is not going to run
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
ping |
tornaria
added a commit
to tornaria/void-packages
that referenced
this pull request
Dec 26, 2023
…tep() This function contains the logic that determines whether the check step will be skipped for the current pkg, taking into account `make_check`. Use this new function in `install_pkg_deps()` so that it uses a more accurate condition to skip installing check dependencies. For instance, check dependencies for a pkg with `make_check=extended` will no longer be installed when using `-Q`. Similar for `make_check=ci-skip`. Replaces: void-linux#46207
|
Closing in favor of #47888 |
sgn
pushed a commit
that referenced
this pull request
Apr 8, 2024
…tep() This function contains the logic that determines whether the check step will be skipped for the current pkg, taking into account `make_check`. Use this new function in `install_pkg_deps()` so that it uses a more accurate condition to skip installing check dependencies. For instance, check dependencies for a pkg with `make_check=extended` will no longer be installed when using `-Q`. Similar for `make_check=ci-skip`. Replaces: #46207
atweiden
added a commit
to atweiden/voidpkgs
that referenced
this pull request
Apr 8, 2024
…tep() This function contains the logic that determines whether the check step will be skipped for the current pkg, taking into account `make_check`. Use this new function in `install_pkg_deps()` so that it uses a more accurate condition to skip installing check dependencies. For instance, check dependencies for a pkg with `make_check=extended` will no longer be installed when using `-Q`. Similar for `make_check=ci-skip`. Replaces: void-linux/void-packages#46207 void-linux/void-packages@ebe2612
snwnde
pushed a commit
to snwnde/void-packages
that referenced
this pull request
Apr 18, 2024
…tep() This function contains the logic that determines whether the check step will be skipped for the current pkg, taking into account `make_check`. Use this new function in `install_pkg_deps()` so that it uses a more accurate condition to skip installing check dependencies. For instance, check dependencies for a pkg with `make_check=extended` will no longer be installed when using `-Q`. Similar for `make_check=ci-skip`. Replaces: void-linux#46207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful e.g. to break build <-> check cycles.
For instance, one can set
make_check=extendedso check doesn't run on CI or -Q (maybe the check depencies are updated at the same time), but it's still easy to run check using -K after dependencies have been built.I'm working on jupyter notebook packages, and there are a few build <-> check cycles. I want to try to arrange checks so that
-Qwill check as much as possible without cycles, and-Kwill do full check (assuming all dependencies are already packaged).Without this patch one needs to add packages to
checkdependsconditionally on$XBPS_CHECK_PKGS, but it seems simpler this way.Testing the changes