Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxWidgets, wxPython #46237

Closed
wants to merge 43 commits into from
Closed

wxWidgets, wxPython #46237

wants to merge 43 commits into from

Conversation

ahesford
Copy link
Member

@ahesford ahesford commented Sep 25, 2023

Our wxWidgets/wxPython stack is pretty old, and it may be more trouble to patch for Python 3.12 than just updating these packages. Thus I would like to:

  • Drop pcsx2, perl-Alien-wxWidgets and dispcalGUI (cc: @lemmi). The first two don't seem well-maintained, and all three rely on wxWidgets with GTK2 support that should be retired. dispcalGUI also requires the long-past-EOL Python 2.
  • With these three dependants gone, we can remove wxWidgets and wxPython.
  • This simplifies the update to wxWidgets-gtk3 and (hopefully---I'm still working) wxPython4.
  • While we're at it, we can transition wxPython4 back to its proper name, just wxPython.

[ci skip]

closes #44849

@ahesford ahesford marked this pull request as draft September 25, 2023 04:42
@classabbyamp
Copy link
Member

classabbyamp commented Sep 25, 2023

this should enable moving forward with #44849

@lemmi
Copy link
Member

lemmi commented Sep 25, 2023

Yes, if #44849 works with that, we can finally drop dispcalGUI.

@ahesford ahesford force-pushed the wxwidgets branch 2 times, most recently from cffca6a to 6a821c3 Compare September 25, 2023 12:35
@ahesford
Copy link
Member Author

ahesford commented Sep 25, 2023

There are five failures on an x86_64 build:

  • OpenCPN
  • audacity
  • codeblocks
  • codelite
  • kicad

@ahesford ahesford force-pushed the wxwidgets branch 3 times, most recently from 47d219d to f76f1d3 Compare September 25, 2023 15:52
@ahesford
Copy link
Member Author

All packages build natively after adopting some patches from @sgn in #39491 (plus a few extra for codeblocks) and updating OpenCPN to 5.8.4 (cc @Johnnynator). I'll start running through all other architectures and also do some run tests.

@classabbyamp
Copy link
Member

classabbyamp commented Sep 25, 2023

can confirm that DisplayCAL (the fork) works (runs without the previous errors) with this PR on x86_64, you can grab this commit instead of the removal if you'd like and @lemmi is ok with it

@classabbyamp
Copy link
Member

also you have a double revbump for kicad, not sure if intentional

@ahesford ahesford changed the title [WIP] wxWiwdgets, wxPython [WIP] wxWidgets, wxPython Sep 25, 2023
Nothing requires this package, it depends on an old and to-be-removed
vesion of wxWidgets, and it doesn't seem to have been updated since it
was added 5 years ago.
This package only builds for i686* and depends on an old and
to-be-removed version of wxWidgets.
@ahesford
Copy link
Member Author

I pulled in the DisplayCAL changes and fixed the double revbump; now I'm shaking out some bugs when building with other arches. When everything builds cleanly, I'll do some run testing.

@ahesford ahesford force-pushed the wxwidgets branch 4 times, most recently from 79f6b0a to 99bab9e Compare September 25, 2023 23:53
@ahesford ahesford marked this pull request as ready for review September 26, 2023 13:44
@ahesford ahesford changed the title [WIP] wxWidgets, wxPython wxWidgets, wxPython Sep 26, 2023
@ahesford ahesford closed this in a758ef3 Sep 26, 2023
@ahesford ahesford deleted the wxwidgets branch September 26, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants