Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update udisks2, libblockdev, and libnvme #46259

Closed
wants to merge 3 commits into from
Closed

Update udisks2, libblockdev, and libnvme #46259

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 26, 2023

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl

Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be one commit per package

conf_files="/etc/libblockdev/conf.d/10-lvm-dbus.cfg
/etc/libblockdev/conf.d/00-default.cfg"
checksum=0f2872830293f3e222832903d80de4c38e06a9c3ea18915b3263272a72095ea8
conf_files="/etc/libblockdev/3/conf.d/10-lvm-dbus.cfg /etc/libblockdev/3/conf.d/00-default.cfg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change will result in the previous conf_files being removed even if modified. it may be better to change blockdev to look for these files not in the 3 dir

Copy link
Author

@ghost ghost Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally left it the same as what is already there (i.e, looks in /etc/libblockdev/conf.d) but it ran into a "configuration file could not be found in DESTDIR" error for both

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will require some manual steps either in the code, in the template, or in the configure args

srcpkgs/udisks2/template Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Sep 26, 2023

this should be one commit per package

I thought one PR was better than multiple, unless there's a way to add multiple commits to a PR? (sorry Im new to git)

@classabbyamp
Copy link
Member

yes, you've already added multiple commits

@ghost ghost closed this by deleting the head repository Oct 5, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants