Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

power-profiles-daemon: create /var/lib/power-profiles-daemon #46521

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

motorto
Copy link
Contributor

@motorto motorto commented Oct 8, 2023

@oreo639
Fixes the following warning, that spams the log:

daemon.notice: Oct  8 17:58:12 power-profiles-daemon: ** (power-profiles-daemon:833): WARNING **: 17:58:12.124: Could not save configuration file '/var/lib/power-profiles-daemon/state.ini': Failed to create file ?/var/lib/power-profiles-daemon/state.ini.AKGIC2?: No such file or directory

Testing the changes

  • I tested the changes in this PR: YES

@oreo639
Copy link
Member

oreo639 commented Oct 8, 2023

Lgtm, sorry for not looking into it sooner.

For reference:
https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/blob/main/src/power-profiles-daemon.c#L306
https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/blob/main/src/power-profiles-daemon.c#L270
And the daemon can only run as root.

Although I don't see any warnings in my syslog for some reason.

@motorto
Copy link
Contributor Author

motorto commented Oct 8, 2023

Although I don't see any warnings in my syslog for some reason.

They should appear when changing the profile. (from balanced -> performance as an example)

And the daemon can only run as root.

Yes I am running it at boot with runit

@oreo639
Copy link
Member

oreo639 commented Oct 8, 2023

Yes I am running it at boot with runit

Yeah, I'm just saying that ownership of make_dirs is correct, although the permissions probably can be made readable by everyone.

@motorto
Copy link
Contributor Author

motorto commented Oct 8, 2023

Yes I am running it at boot with runit

Yeah, I'm just saying that ownership of make_dirs is correct, although the permissions probably can be made readable by everyone.

644 then ?

@oreo639
Copy link
Member

oreo639 commented Oct 8, 2023

No, the folder would need to be 0755 for its contents to be readable.

Fixes the following warning, that spams the log

```
daemon.notice: Oct  8 17:58:12 power-profiles-daemon: ** (power-profiles-daemon:833): WARNING **: 17:58:12.124: Could not save configuration file '/var/lib/power-profiles-daemon/state.ini': Failed to create file ?/var/lib/power-profiles-daemon/state.ini.AKGIC2?: No such file or directory
```
@motorto motorto force-pushed the power-profiles-daemon-var-fix branch from 2fd93a8 to 2977793 Compare October 9, 2023 09:53
@sgn sgn merged commit c6cc25a into void-linux:master Oct 10, 2023
4 of 8 checks passed
@motorto motorto deleted the power-profiles-daemon-var-fix branch October 10, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants