Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-Cython: fix memory leak + debug output for generators #46553

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

tornaria
Copy link
Contributor

cython/cython#5690
cython/cython#5725

Both are merged in cython 3.0.3, however that release breaks scipy.

Testing the changes

  • I tested the changes in this PR: briefly

The memory leak was detected due to 3 doctest failures in sagemath (when built with cython 3) and this PR fixes it.

The debug output issue symptom is that sagemath can't be built unless one sets SAGE_DEBUG=no (however, this only triggers when python3-lxml is installed).

cc: @ahesford

cython/cython#5690
cython/cython#5725

Both are merged in cython 3.0.3, however that release breaks scipy.
@tornaria
Copy link
Contributor Author

tornaria commented Oct 10, 2023

Alternatively, we could try updating to 3.0.3 + cython/cython#5752 which claims to fix the scipy build regression. I haven't tested that one though.

Edit: or just wait for 3.0.4. This only affects sagemath with cython 3 which is not what we ship. I already have patched cython in my development box. As long as this is fixed by the time sagemath 10.2 is released (cython 3 only), we'll be fine.

@ahesford
Copy link
Member

Thanks for digging into this. Because you know this fixes issues with sagemath, let's take these patches for now and wait to see if Cython 3.0.4 fixes SciPy builds.

@ahesford ahesford merged commit d111f2f into void-linux:master Oct 10, 2023
8 checks passed
@tornaria tornaria deleted the cython branch October 10, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants