Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connman: build with iwd support #46608

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

rookiejet
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Allows using iwd instead of wpa_supplicant for wireless connections.

@cinerea0
Copy link
Contributor

Does this mean the explicit dependency on wpa_supplicant should be removed, and backends listed in a README.voidlinux file?

@rookiejet
Copy link
Contributor Author

rookiejet commented Oct 12, 2023

Yes, wpa_supplicant is an optional dependency. Per the src readme it's not required during build time to enable support for it in connman, it's only a runtime dependency.

Edit: Amended

@ahesford
Copy link
Member

Removing wpa_supplicant may break some users' installations if they remove orphans. I think the dependency should be kept for now and an INSTALL.msg should be added for a couple of release cycles to note that the dependency will be removed in the future and that users relying on it should mark wpa_supplicant manually installed.

@rookiejet
Copy link
Contributor Author

That's reasonable. wpa_supplicant is actually a dependency of base-system as well, so it won't be orphaned and uninstalled if it is removed from here. Would that suffice for this merge?

@ahesford
Copy link
Member

Not everybody uses base-system, so relying on its dependencies to not break connman is insufficient.

@rookiejet
Copy link
Contributor Author

I revised the commit with @ahesford's recommendation, and included an INSTALL.msg

@ahesford ahesford merged commit 5001f1b into void-linux:master Oct 19, 2023
8 checks passed
@rookiejet rookiejet deleted the connman-iwd branch October 19, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants