Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-Levenshtein: update to 0.23.0 #46624

Merged
merged 4 commits into from Nov 23, 2023

Conversation

chrysos349
Copy link
Contributor

@chrysos349 chrysos349 commented Oct 11, 2023

fixes #46581
fixes #46545

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl x
    • armv7l x
    • armv6l-musl x

Comment on lines 17 to 24
pre_build() {
# ugly hack to help cmake find python3 headers
if [ "$CROSS_BUILD" ]; then
rm -rf ${XBPS_BUILDDIR}/../${py3_inc}
ln -sf ${XBPS_BUILDDIR}/../${XBPS_CROSS_BASE}/${py3_inc} \
${XBPS_BUILDDIR}/../${py3_inc}
fi
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't do this, there should be a cmake flag that can be passed to tell it where things are.

zap and re-binary-bootstrap your masterdirs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahesford
Copy link
Member

Drop the README.voidlinux on RapidFuzz. There's not a lot of value in a two-line file that says "you can use this with numpy", and the optional dependency isn't really a specific consideration of Void. Users of RapidFuzz should be expected to understand how to use it with or without optional dependencies.

@chrysos349
Copy link
Contributor Author

@ahesford dropped.

@chrysos349
Copy link
Contributor Author

updated python3-rapidfuzz to 3.4.0

@abenson abenson merged commit 7418d7e into void-linux:master Nov 23, 2023
8 checks passed
@chrysos349 chrysos349 deleted the python3-Levenshtein branch January 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python3-Levenshtein broken with Python 3.12 Ulauncher broken after python 3.12 upgrade
4 participants