Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp #46693

Closed
wants to merge 2 commits into from

Conversation

paper42
Copy link
Member

@paper42 paper42 commented Oct 15, 2023

Testing the changes

  • I tested the changes in this PR: YES

it would be better if we could fix gpodder and other packages properly, but this is a hacky solution to make it easily work, opinions?

Closes: #46683

@ahesford
Copy link
Member

In this case, I think it's better to just patch gpodder. The patch seems to be the replacement of a single import imp and call to imp.load_source in src/gpodder/extensions.py with the alternative load_source function recommended by Python.

If the patch were more extensive, it might be worth carrying this package (even though upstream says not to use it and imp has been deprecated for nine years). I also think it would be more tolerable as a build dependency for some complex package than as a runtime dependency.

@classabbyamp classabbyamp added the new-package This PR adds a new package label Oct 15, 2023
@auouymous
Copy link

gpodder/gpodder#1571 contains a patch to replace imp. I have not tested gPodder on 3.12, so it might require additional patches.

@ahesford Thanks for the information.

Piraty added a commit to Piraty/void-packages that referenced this pull request Oct 27, 2023
Piraty added a commit to Piraty/void-packages that referenced this pull request Oct 27, 2023
@Piraty
Copy link
Member

Piraty commented Oct 27, 2023

thank you @auouymous , i picked the relevant parts from your branch, see #46934

classabbyamp pushed a commit that referenced this pull request Nov 13, 2023
zen0bit pushed a commit to oSoWoSo/VUR that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpodder-3.11.1_2 fails to start due to python3-3.12.0_1
5 participants