New package: grandorgue-3.13.0 #46711
Conversation
nicolodavis
force-pushed
the
grandorgue
branch
from
ddcb42b
to
782d721
Compare
nicolodavis
force-pushed
the
grandorgue
branch
from
782d721
to
b3e0f47
Compare
|
Just curious if I need to do anything at my end to get the CI to green tick this PR? |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
Hi @classabbyamp, is Void still accepting new package contributions? Let me know if I should close this PR instead. |
|
we do accept new package contributions, but generally it requires a maintainer to be either interested in the package or see the utility of merging it we also generally like to see new contributors make some contributions (updates, fixes, etc) to existing packages (especially orphaned packages) before adding new packages. |
| revision=1 | ||
| archs="x86_64" | ||
| build_style="cmake" | ||
| configure_args="-DCMAKE_BUILD_TYPE=Release -G Ninja" |
There was a problem hiding this comment.
neither of these need to be set. void sets the build type to None and the generator to ninja by default in common/build-style/cmake.sh
| export WX_CONFIG=wx-config-gtk3 | ||
|
|
||
| do_fetch() { | ||
| git clone --recurse-submodules --depth 1 --branch ${version}-${revision} https://github.com/GrandOrgue/grandorgue.git ${wrksrc} |
There was a problem hiding this comment.
do not use git clone to fetch. if a packages has submodules, they should be added as distfiles. see the edk2-ovmf template for an example.
| license="GPL-2.0-or-later" | ||
| homepage="https://github.com/GrandOrgue/grandorgue" | ||
|
|
||
| export WX_CONFIG=wx-config-gtk3 |
There was a problem hiding this comment.
this can probably be replaced with build_helper="cmake-wxWidgets-gtk3"
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
New package
Local build testing