Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuimoji: disable test #46810

Closed
wants to merge 1 commit into from
Closed

tuimoji: disable test #46810

wants to merge 1 commit into from

Conversation

Luciogi
Copy link
Contributor

@Luciogi Luciogi commented Oct 21, 2023

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glib)

@Luciogi Luciogi force-pushed the tuimoji branch 2 times, most recently from d623cdb to bbc95f5 Compare October 25, 2023 13:44
srcpkgs/tuimoji/template Outdated Show resolved Hide resolved
@ahesford
Copy link
Member

@Luciogi
Copy link
Contributor Author

Luciogi commented Nov 26, 2023

This isn't actually running tests.

https://github.com/void-linux/void-packages/actions/runs/6996075093/job/19031580372?pr=46810#step:7:125

actually tests does not exist (https://github.com/Fingel/tuimoji)

Is it fine to use make_check=no?

@ahesford
Copy link
Member

This isn't actually running tests.
https://github.com/void-linux/void-packages/actions/runs/6996075093/job/19031580372?pr=46810#step:7:125

actually tests does not exist (https://github.com/Fingel/tuimoji)

Is it fine to use make_check=no?

Yes, remove the checkdepends and disable tests.

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is not accurate, because tests have been disable, not fixed.

@Luciogi Luciogi changed the title tuimoji: fix test tuimoji: disable test Nov 27, 2023
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Feb 26, 2024
@Luciogi Luciogi closed this Mar 6, 2024
@Luciogi Luciogi deleted the tuimoji branch March 6, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants