Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sagemath: update to 10.2, flintlib: update to 3.0.1 #46832

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

tornaria
Copy link
Contributor

@tornaria tornaria commented Oct 22, 2023

Testing the changes

  • I tested the changes in this PR: YES

This is a major update for both sagemath and flintlib.

Sagemath moves to cython 3.

A couple of packages need rebuild or update:

  • eclib: rbuild for flintlib-3.0.1
  • singular: update to 4.3.2p10
  • python3-pplpy: rebuild using cython 3
  • python3-networkx: update to 3.2.1.

@dkwo
Copy link
Contributor

dkwo commented Oct 29, 2023

Excellent. This builds and checks fine on aarch64, after rebasing.

@tornaria tornaria changed the title [WIP] flintlib: update to 3.0.0. [WIP] flintlib: update to 3.0.0 / track sagemath 10.2 betas Oct 31, 2023
@tornaria tornaria changed the title [WIP] flintlib: update to 3.0.0 / track sagemath 10.2 betas [WIP] flintlib: update to 3.0.0 / track sagemath-10.2 prereleses Oct 31, 2023
@tornaria tornaria changed the title [WIP] flintlib: update to 3.0.0 / track sagemath-10.2 prereleses [WIP] flintlib: update to 3.0.0 / track sagemath-10.2 prereleases Oct 31, 2023
@tornaria tornaria changed the title [WIP] flintlib: update to 3.0.0 / track sagemath-10.2 prereleases [WIP] flintlib: update to 3.0.0, sagemath: update 10.2 (RC) Nov 7, 2023
@tornaria tornaria changed the title [WIP] flintlib: update to 3.0.0, sagemath: update 10.2 (RC) [RC] sagemath: update to 10.2, flintlib: update to 3.0.1 Nov 10, 2023
@tornaria
Copy link
Contributor Author

@dkwo sagemath is on its second RC so it will be released soon. This PR will be ready to merge once the release happens. It should ideally be tested together with #46785 and #46787.

@tornaria tornaria force-pushed the flintlib branch 3 times, most recently from 9ae29da to d8aae58 Compare November 15, 2023 00:51
@dkwo
Copy link
Contributor

dkwo commented Nov 15, 2023

Can flint (and possibly sage) be built without ntl after this update?
i read somewhere that ntl might not be necessary anymore, and this would ease the burden of cross compiling.

@dkwo
Copy link
Contributor

dkwo commented Nov 15, 2023

possibly eclib as well?

@tornaria
Copy link
Contributor Author

Can flint (and possibly sage) be built without ntl after this update? i read somewhere that ntl might not be necessary anymore, and this would ease the burden of cross compiling.

I think flintlib is already cross-compiled.

As for eclib, it lists ntl-devel in makedepends. Have you tried building it cross without ntl-devel? If it works, we can just add a build option ntl that is disabled by default in cross builds. However, I think that eclib actually uses ntl for some things.

As for sagemath, I think it has a few more nocross makedepends. The comment in the template list some; including flintlib, but I'm not sure this is a mistake. It's possible that sagemath needs a flintlib that was built with ntl.

@tornaria tornaria force-pushed the flintlib branch 2 times, most recently from f570c14 to 7c59807 Compare November 18, 2023 04:51
srcpkgs/sagemath/template Outdated Show resolved Hide resolved
@dkwo
Copy link
Contributor

dkwo commented Nov 19, 2023

The current iteration (rc4) has a couple of test failures on aarch64:

sage/libs/gap/element.pyx (killed due to segfault)
sage/matrix/matrix_integer_dense.pyx (killed due to segfault)
sage/graphs/generic_graph.py (timed out)

With regard to the crossbuild, I will investigate eclib and flint (in the past, our crossbuilt flintlib was giving a doctest error in sage).

@dkwo
Copy link
Contributor

dkwo commented Nov 20, 2023

(previously, I was testing with XBPS_CHECK_PKGS=yes, yesterday I switched to full.)

@tornaria
Copy link
Contributor Author

The current iteration (rc4) has a couple of test failures on aarch64:

sage/libs/gap/element.pyx (killed due to segfault)
sage/matrix/matrix_integer_dense.pyx (killed due to segfault)
sage/graphs/generic_graph.py (timed out)

With regard to the crossbuild, I will investigate eclib and flint (in the past, our crossbuilt flintlib was giving a doctest error in sage).

Can you try running those tests again? At least the matrix_integer_dense.pyx I think I've seen from time to time as a random segfault. The others I don't know, if you can reproduce consistently, then try to see what triggers it, get a minimal example that reproduces the issue, and submit a bug report upstream.

@tornaria tornaria changed the title [RC] sagemath: update to 10.2, flintlib: update to 3.0.1 sagemath: update to 10.2, flintlib: update to 3.0.1 Dec 3, 2023
@tornaria tornaria marked this pull request as ready for review December 3, 2023 16:18
@tornaria
Copy link
Contributor Author

tornaria commented Dec 3, 2023

@dkwo this is ready to merge, any comments?

@dkwo
Copy link
Contributor

dkwo commented Dec 3, 2023

looks good to me.
i only see this failure on aarch64 with full check: sage/graphs/generic_graph.py (timed out).
@leahneukirchen can this be merged?

@dkwo
Copy link
Contributor

dkwo commented Dec 3, 2023

that test passes when run from within installed sage.
all looks good :)

@leahneukirchen leahneukirchen merged commit a265508 into void-linux:master Dec 8, 2023
8 checks passed
@tornaria tornaria deleted the flintlib branch December 8, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants