-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: atheme-7.2.12 #46956
base: master
Are you sure you want to change the base?
New package: atheme-7.2.12 #46956
Conversation
2e00e6c
to
1518745
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/etc/atheme.conf.example
/etc/atheme.conf.operserv-example
/etc/atheme.conf.userserv-example
/etc/atheme.cron.example
/etc/atheme.motd
/etc/atheme.motd.example
(most of) these should probably be vsconf
ed instead of directly in /etc
/usr/include
, the pkgconfig file, and the non-versioned .so
symlink should be put in an atheme-devel
subpkg (you can use xnew -a atheme atheme-devel
to autogen most of this)
srcpkgs/atheme/template
Outdated
changelog="https://github.com/atheme/atheme/releases" | ||
distfiles="https://github.com/atheme/atheme/releases/download/v$version/atheme-services-v$version.tar.xz" | ||
checksum=600d5ba0e25d80307818021fd9b85e49b07f245932b3c8e04e16fe312dd60fba | ||
conflicts="ecdsautils lifelines" # /usr/bin/ecdsakeygen and /usr/bin/dbverify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to change the names of these to atheme-ecdsakeygen
and atheme-dbverify
?
1518745
to
27d26f6
Compare
Thanks for taking a review!
On Sun, Oct 29, 2023 at 10:14:58AM -0700, classabbyamp wrote:
/etc/atheme.conf.example
/etc/atheme.conf.operserv-example
/etc/atheme.conf.userserv-example
/etc/atheme.cron.example
/etc/atheme.motd
/etc/atheme.motd.example
(most of) these should probably be `vsconf`ed instead of directly in /etc
Opsy, didn't realise that. I've gone with `--sysconfdir=/etc/atheme`
which should do the same thing.
`/usr/include`, the pkgconfig file, and the non-versioned `.so`
symlink should be put in an `atheme-devel` subpkg (you can use `xnew
-a atheme atheme-devel` to autogen most of this)
Thanks for the xnew tip!
would it make sense to change the names of these to
`atheme-ecdsakeygen` and `atheme-dbverify`?
I'll be honest, I don't know how those are used. But if it avoids a
conflict I think we should.
Updated PR :D
|
27d26f6
to
8f37472
Compare
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
8f37472
to
6261a27
Compare
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Marking this PR as a draft due to incompatibilities with newer crypto lib, and waiting for a new atheme release (it's been so long since I looked at this I honestly am not sure how to describe the issue) |
6261a27
to
30cdd7b
Compare
Testing the changes
I tested the changes in this PR: YES
This new package conforms to the package requirements: YES
Local build testing
Built on x86_64-glibc, tested on aarch64-musl with ngircd