Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrcpy: update to 2.3 #47016

Closed
wants to merge 1 commit into from
Closed

Conversation

devlocalhost
Copy link

Testing the changes

  • I tested the changes in this PR: YES

@devlocalhost
Copy link
Author

scrcpy 2.2 adds a new feature which allows you to use your phones camera as a webcam: http://0x0.st/Hy08.png

@triallax
Copy link
Contributor

triallax commented Nov 2, 2023

It looks good, but you have to use an actual e-mail address for your commit (this is why the lint GitHub action failed). To do so, run these commands (replacing john.doe@example.com with your actual e-mail address, not a GitHub-provided one):

$ git config --global user.email john.doe@example.com
$ git commit --amend --reset-author
$ git push -f

@lemmi
Copy link
Member

lemmi commented Nov 2, 2023

I'll quickly mention @daniel-eys, since they did the last couple of updates.

@devlocalhost
Copy link
Author

devlocalhost commented Nov 2, 2023

linting failed again, why? i followed the steps mhmdanas told me
(the localhost in my username, thats why its failing)

@daniel-eys
Copy link
Contributor

Works for me, but the new camera feature seems to have some issues Genymobile/scrcpy#4392

@daniel-eys
Copy link
Contributor

2.3 has been released which fixes the camera issues 🎉

@devlocalhost
Copy link
Author

devlocalhost commented Nov 26, 2023

Bumped version, but I didn't test (build on my machine) because it's 4 am lol. Will check in the morning

A question: should I update the PR's name? (2.2 to 2.3)

@daniel-eys
Copy link
Contributor

Bumped version, but I didn't test (build on my machine) because it's 4 am lol. Will check in the morning

A question: should I update the PR's name? (2.2 to 2.3)

yes and please squash the commits into one

@devlocalhost devlocalhost changed the title scrcpy: update to 2.2 scrcpy: update to 2.3 Nov 26, 2023
lemmi pushed a commit to lemmi/void-packages that referenced this pull request Nov 27, 2023
Closes: void-linux#47016 [via git-merge-pr]
@devlocalhost
Copy link
Author

devlocalhost commented Nov 28, 2023

Bumped version, but I didn't test (build on my machine) because it's 4 am lol. Will check in the morning

A question: should I update the PR's name? (2.2 to 2.3)

tested (compiles. no issues), works fine

lemmi pushed a commit to lemmi/void-packages that referenced this pull request Dec 5, 2023
Closes: void-linux#47016 [via git-merge-pr]
lemmi pushed a commit to lemmi/void-packages that referenced this pull request Dec 9, 2023
Closes: void-linux#47016 [via git-merge-pr]
@biopsin
Copy link
Contributor

biopsin commented Jan 11, 2024

surpassed @ #47926

@devlocalhost
Copy link
Author

devlocalhost commented Jan 11, 2024

I wonder why my PR wasn't already pushed...

@devlocalhost devlocalhost deleted the patch-1 branch February 15, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants