Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkinitcpio: add zstd dependency #47031

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

tranzystorekk
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

cc @ahesford

@classabbyamp
Copy link
Member

new version is coming pretty soon, is this super urgent?

@tranzystorekk
Copy link
Contributor Author

@classabbyamp not really, i can close, just gotta remember to include these changes

@ahesford
Copy link
Member

ahesford commented Nov 2, 2023

zstd is optional because not all kernels we ship use zstd-compressed modules and, even for those that do, the errors printed when mkinitcpio tries to decompress the modules by default (which can be disabled) don't prevent the original, compressed modules from being included.

Nevertheless, if the errors are alarming to users and the solution (installing zstd) isn't obvious, we can add the dependency.

@ahesford
Copy link
Member

I pushed the update to v37 and included the homepage change. Using the Gitlab archive in distfiles breaks the version number recorded in /usr/bin/mkinitcpio, so I reverted to sources.archlinux.org for a tarball that contains proper version information.

I'm still on the fence about zstd and didn't include that in the depends with the latest update.

@ahesford
Copy link
Member

It turns out that Arch considers zstd a hard requirement even as they use the optdepends mechanism for other compressors: https://gitlab.archlinux.org/archlinux/packaging/packages/mkinitcpio/-/blob/main/PKGBUILD

That makes a convincing enough argument that we should just pull it in, so we can merge this if you rebase.

@tranzystorekk tranzystorekk changed the title mkinitcpio: update source, add zstd dependency mkinitcpio: add zstd dependency Nov 18, 2023
@ahesford ahesford merged commit 9740b1a into void-linux:master Nov 18, 2023
8 checks passed
@tranzystorekk tranzystorekk deleted the mkinitcpio branch November 18, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants