Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: update to 20.9.0 #47249

Closed
wants to merge 1 commit into from
Closed

nodejs: update to 20.9.0 #47249

wants to merge 1 commit into from

Conversation

rfl890
Copy link

@rfl890 rfl890 commented Nov 15, 2023

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@triallax
Copy link
Contributor

Thanks for your PR! I see you're taking on quite a heavy package for your first contribution to void-packages...

First thing, please don't close your PRs and open new ones just to change some things; instead, amend your commit using git commit --amend and then force-push to the PR's branch.

As for the PR itself, first thing, please pull in my changes in paper42#7 (except for the ${makejobs} one, ignore it). Other than that, I'm afraid just testing that node works correctly isn't nearly enough: you also need to make sure that everything that depends on node for building still works correctly, can you please do that?

@rfl890
Copy link
Author

rfl890 commented Nov 15, 2023

@mhmdanas
Okay, I've merged your changes. According to xbps-query -RX nodejs, there are 10 packages that depend on nodejs excluding nodejs-lts. From what I understand, I need to build all of them from source and test them?

@triallax
Copy link
Contributor

Okay, I've merged your changes. According to xbps-query -RX nodejs, there are 10 packages that depend on nodejs excluding nodejs-lts. From what I understand, I need to build all of them from source and test them?

No, what you found are the packages that depend on nodejs at runtime, but what I meant are packages that have nodejs in makedepends or hostmakedepnends. Also, you don't strictly need to test all of them, though that's still a good idea if possible.

@rfl890
Copy link
Author

rfl890 commented Nov 15, 2023

After a bit of digging, I found these packages:

Rocket.Chat-Desktop
Signal-Desktop
ansible-language-server
bismuth
chronograf
electron19
electron24
element-desktop
imgbrd-grabber
keybase-desktop
ntfy
pnpm
pyright
python3-jupyter_nbformat
qt5-webengine
qt5-webengine-devel
qt6-webengine
qt6-webengine-devel
qt6-webengine-examples
rapydscript-ng
riot-desktop
spreed-webrtc
vscode
wire-desktop
yarn

I'll test a few of them today.

@triallax
Copy link
Contributor

Sorry, another clarification: ideally you would run test builds for ALL of these packages, but it's fine to install and manually test some of them. However, the thing is, there are some packages in there that take a lot of resources and time to build (e.g. qt5-webengine), so it might not be feasible to do it yourself depending on your resources...

@rfl890
Copy link
Author

rfl890 commented Nov 17, 2023

Maybe not.

@rfl890 rfl890 closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants