Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish-shell: update to 3.6.4. #47619

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fish-shell: update to 3.6.4. #47619

merged 1 commit into from
Dec 22, 2023

Conversation

akierig
Copy link
Contributor

@akierig akierig commented Dec 6, 2023

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl

@akierig akierig marked this pull request as ready for review December 6, 2023 15:58
@triallax
Copy link
Contributor

triallax commented Dec 6, 2023

The release is just a test fix, is it worth the bump?

@akierig
Copy link
Contributor Author

akierig commented Dec 6, 2023

@mhmdanas is there a reason not to keep the versions in sync? Is there some big overhead i don't know about?

@triallax
Copy link
Contributor

triallax commented Dec 7, 2023

Nothing in particular, a rebuild just seems unnecessary to me, especially seeing as the tests are already passing for 3.6.3 on Void (#47574).

This is just my two cents though, it's not the end of the world if fish-shell is rebuilt :D

@Duncaen Duncaen merged commit e3f4634 into void-linux:master Dec 22, 2023
8 checks passed
@akierig akierig deleted the fish-3.6.4 branch January 18, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants