Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: usbimager-1.0.10 #47851

Closed
wants to merge 1 commit into from

Conversation

filiprojek
Copy link
Contributor

Closes: #42758

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@classabbyamp classabbyamp added the new-package This PR adds a new package label Dec 20, 2023
@filiprojek filiprojek marked this pull request as draft December 23, 2023 20:50
version=1.0.10
revision=1
build_style=gnu-makefile
hostmakedepends="libX11-devel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be makedepends=, not hostmakedepends=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I make this change, the package can no longer be compiled for any architecture

@Luciogi
Copy link
Contributor

Luciogi commented Dec 24, 2023

build_style=gnu-makefile
when template mentions , build_style variable, then you dont have have to declare functions like do_build and do_install
xbps-src will do build and install automatically

--- if it fails to build automatically, then you can write custom functions for build and install

If I said anything correct me reviewers

@filiprojek
Copy link
Contributor Author

When I try to build the package using build_style=gnu-makefile, the package reports an error about missing libraries.
There's some problem with the vendored libraries. @Duncaen advised me on irc to try to link system libraries instead of using vendored ones

I managed to build a package for x86_64-musl on my local machine. I have no idea why the package reports an error here.

I have not been able to build a package for these architectures:

  • aarch64
  • armv7l
  • armv6l-musl
  • aarch64-musl

On aarch64 there is this error:
/usr/bin/aarch64-linux-gnu-strip: Unable to recognise the format of the input file '/destdir/aarch64-linux-gnu/usbimager-1.0.10/usr/bin/usbimager'
@classabbyamp advised me that Makefile probably ignores cflags

Until I can fix them, I have masked them in the template.

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 25, 2024
@github-actions github-actions bot closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: usbimager
3 participants