Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backintime: update to 1.4.3. #47880

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

thetredev
Copy link
Contributor

@thetredev thetredev commented Dec 22, 2023

Testing the changes

  • I tested the changes in this PR: YES. The Qt GUI launches and I can setup backup targets. The CLI runs and doesn't complain, but I don't know how to use it so I assume it's fine also.

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

Questions to maintainers

  • The package revision has been reset to 1, because the minor version changed to 4. Please tell me if this is correct.

Further Notes

  • The patch srcpkgs/backintime/patches/e1ae23ddc0b4229053e3e9c6c61adcb7f3d8e9b3.patch has been deleted because it is included in backintime 1.4.1 (see bit-team/backintime@e1ae23d).

@Duncaen
Copy link
Member

Duncaen commented Dec 22, 2023

backintime_package defines a sub package by the main package name. The files are already in the package backintime, backintime-qt moves them out of it. If you want to keep the files in backintime they simply don't get moved, no need to define backintime_package. Not sure what files you actually want to move where though.

@thetredev
Copy link
Contributor Author

Gotcha thanks. I'll try to remove backintime_package and see how it goes.

@thetredev
Copy link
Contributor Author

thetredev commented Dec 23, 2023

That worked, thanks! Now I understand why it didn't work before: the new package version doesn't have a couple files/folders that were listed in backintime-qt_package.

PR branch is updated.

@thetredev thetredev changed the title backintime: update to 1.4.1. backintime: update to 1.4.3. Mar 9, 2024
@thetredev
Copy link
Contributor Author

thetredev commented Mar 9, 2024

Rebased to lastest master, updated the package to version v1.4.3

Edit: Sorry, messed up the commit history... my local clone wasn't right. Will fix it asap.

@thetredev thetredev force-pushed the update-package/backintime branch 3 times, most recently from 3e28c0b to 938c71a Compare March 11, 2024 00:28
@thetredev
Copy link
Contributor Author

thetredev commented Mar 11, 2024

Okay, now it's ready to be merged.

Edit: @Duncaen @classabbyamp python3-packaging was missing. Now it can really be merged :)

Copy link

github-actions bot commented Jun 9, 2024

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 9, 2024
Signed-off-by: Timo Reichl <thetredev@gmail.com>
@thetredev
Copy link
Contributor Author

bump. Rebased to lastest master

@classabbyamp classabbyamp merged commit 95b1e5a into void-linux:master Jun 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants