Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build & check packages in addition to changed templates #47887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tornaria
Copy link
Contributor

To use, add "[ci check pkg1 pkg2 ...]" in PR title or body.

The idea is that sometimes I change some package but I want to test if another package (depending on the changed package) builds and checks ok (example #47610, or when updating ipython / cython / etc try build&check sagemath to see everything is fine, etc).

The implementation is just passing the pr title and body in the environment and have changed_templates.sh scan these for "[ci check ...]"

Testing the changes

  • I tested the changes in this PR: YES

See: https://github.com/tornaria/void-packages/actions/runs/7310706260/job/19919574047

To use, add "[ci check pkg1 pkg2 ...]" in PR title or body.
@classabbyamp
Copy link
Member

i feel like this kind of testing is better suited to local building. tools like ymir and xxbuild can be used to automate building multiple packages in one go

@tornaria
Copy link
Contributor Author

i feel like this kind of testing is better suited to local building. tools like ymir and xxbuild can be used to automate building multiple packages in one go

All testing can be done locally, so why have CI at all then?

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 23, 2024
@tornaria
Copy link
Contributor Author

Ping

@github-actions github-actions bot removed the Stale label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants