wt: add build dependencies #47903
Merged
wt: add build dependencies #47903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danoloan10
force-pushed
the
wt-opts
branch
4 times, most recently
from
b947793
to
cecbe17
Compare
|
this isn't Gentoo, not everything needs to be a build option. some of these don't even make sense, like the qt4 one (we don't have qt4 anymore) |
|
the default config would fix the original issue, because everything is enabled by default on the condition that each dependency package is found. so I guess a full build without options should be ok. in that case should any of these options be kept? |
|
then just add the necessary build dependencies |
Danoloan10
force-pushed
the
wt-opts
branch
4 times, most recently
from
0a43793
to
7ff8234
Compare
Danoloan10
force-pushed
the
wt-opts
branch
2 times, most recently
from
fd2e1c9
to
9d4453e
Compare
Danoloan10
changed the title
Wt's build will silently ignore build options if their respective dependencies are not found, but this does not mean that they should not be used. In fact, the lms package needs wt be built with OpenSSL. Fixes: epoupon/lms#384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes epoupon/lms#384
Testing the changes
Local build testing