Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocket.Chat-Desktop: update to 3.9.11 #47975

Closed
wants to merge 1 commit into from

Conversation

ju-ef
Copy link
Contributor

@ju-ef ju-ef commented Dec 29, 2023

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@ju-ef
Copy link
Contributor Author

ju-ef commented Dec 30, 2023

Couldn't build i686 version (locally built electron24 for i686 arch as there is no such version), even with removed do_configure() block;
also tried to set env variable ELECTRON_SKIP_BINARY_DOWNLOAD=1 - no changes.

[!] Error: Electron failed to install correctly, please delete node_modules/electron and try installing again

Don't know how to fix it.
But maybe because there is yarn set to 3.2.2 version:
https://github.com/RocketChat/Rocket.Chat.Electron/blob/3.9.11/package.json#L161
https://github.com/RocketChat/Rocket.Chat.Electron/blob/3.9.11/.yarnrc.yml#L13

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 30, 2024
@github-actions github-actions bot closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant