Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: swaylock-effects-1.7.0.0 #48075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Clos3y
Copy link
Contributor

@Clos3y Clos3y commented Jan 5, 2024

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • i686 (X)
    • i686-musl (X)
    • x86_64-musl (X)
    • armv6l (X)
    • armv6l-musl (X)

Opening as draft to discuss possible security concerns previously mentioned by @ericonr (#26392 (comment), #27971 (review)). This version is a fork of the now unmaintained original. The maintainer is active, and the current version of jirutka/swaylock-effects is behind swaywm/swaylock by 23 commits. Happy to discuss :)

Also, regarding the template, I'm not sure if it's preferred to have conflicts or replaces? I've gone for the former because the latter would require changing the swaylock template too.

@ahesford
Copy link
Member

ahesford commented Jan 5, 2024

This is a fork of a fork of swaylock. What benefits would this confer, and why chooose this particular fork?

@Clos3y
Copy link
Contributor Author

Clos3y commented Jan 5, 2024

This is a fork of a fork of swaylock. What benefits would this confer, and why chooose this particular fork?

The changes are aesthetic with subjectively 'nicer' screenlocking, so I think I'd be hard pressed to say truthfully there are any benefits, per-se.

As for why this fork, unlike the repo it is forked from (from which people have made the previous PRs), it's being maintained and developed (albeit slowly).

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jan 5, 2024
@Clos3y Clos3y marked this pull request as ready for review March 20, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants