btop: Update to 1.3.2

[zen0bit]

Testing the changes

• I tested the changes in this PR: briefly

Local build testing

• I built this PR locally for my native architecture, (x64 glibc)

[Calandracas606]

Tested and is not working for me on x86-64-musl. CPU bar are missing.

Also, we could add ROCm-SMI-LIB as a dependency for AMD GPU support. I have a template for it, but it is trivial, and has no other dependencies

[mdkcore0]

btop 1.3.2 available

[Calandracas606]

I just tested, and 1.3.2 looks like its working for me on musl

Also I created a PR to add ROCm-SMI-LIB for GPU support: #48744

[zen0bit]

I just tested, and 1.3.2 looks like its working for me on musl

Also I created a PR to add ROCm-SMI-LIB for GPU support: #48744

Definetly will try..

Since btop must be compiled with ROCm support, I think we will need second package for that...

am I right?

[Calandracas606]

Since btop must be compiled with ROCm support, I think we will need second package for that...

ROCm-SMI is a standalone library which doesn't require any additional ROCm components. It pretty much just is an interface to get GPU load, power usage, temps, fan speeds, etc.

[zen0bit]

Since btop must be compiled with ROCm support, I think we will need second package for that...

ROCm-SMI is a standalone library which doesn't require any additional ROCm components. It pretty much just is an interface to get GPU load, power usage, temps, fan speeds, etc.

I am speaking about btop and btop-rocm

[Calandracas606]

I am speaking about btop and btop-rocm

I don't think that there is a need for a second package.

How is it different from other packages we build which have optional dependencies for extended functionality?

[Calandracas606]

I just checked the code and it should dlopen librocm_smi64.so

[zen0bit]

But as I study btop instructions before. ROCm must be presented at build time. If isn't btop should be builded without ROCm support. So provide library for usuall btop shouldn't be enough. Must be builded again with ROCm, as far as I understand...

So only difference will be ROCM_devel in makedepends

repektive somethink like this?:

# Template file for 'btop-ROCm'
pkgname=btop-ROCm
version=1.3.2
revision=1
build_style=gnu-makefile
makedepends="ROCm-SMI-devel"
short_desc="Monitor of resources"
maintainer="RunningDroid <runningdroid@zoho.com>"
license="Apache-2.0"
homepage="https://github.com/aristocratos/btop"
changelog="https://raw.githubusercontent.com/aristocratos/btop/main/CHANGELOG.md"
distfiles="https://github.com/aristocratos/btop/archive/refs/tags/v${version}.tar.gz"
checksum=331d18488b1dc7f06cfa12cff909230816a24c57790ba3e8224b117e3f0ae03e
conflicts=btop

[cinerea0]

I believe what @Calandracas606 is saying is that there is no need to create a new btop-ROCm package, you can simply add ROCm-SMI-devel to btop's makdepends if/when it gets merged.

That said, xbps does not support "optional" dependencies, only build options. Did you mean adding a non-default build option for ROCm-SMI support?

[Calandracas606]

you can simply add ROCm-SMI-devel to btop's makdepends if/when it gets merged.

@cinerea0 what I mean is that btop tries to dlopen librocm_smi, it's not even needed as a makedepends.

//? Try possible library paths and names for librocm_smi64.so
  const array libRocAlts = {"/opt/rocm/lib/librocm_smi64.so",
                            "librocm_smi64.so",
                            "librocm_smi64.so.5",   // fedora
                            "librocm_smi64.so.1.0", // debian
                            "librocm_smi64.so.6"};

  for (const auto &l : libRocAlts) {
    rsmi_dl_handle = dlopen(l, RTLD_LAZY);
    if (rsmi_dl_handle != nullptr) {
      break;
    }
  }

  if (!rsmi_dl_handle) {
    Logger::info(
        "Failed to load librocm_smi64.so, AMD GPUs will not be detected: "s +
        dlerror());
    return false;
  }

All that being said, there appears to be a bug in the gpu code, but I've been able to patch it to get it working

[Calandracas606]

made a bug report upstream, but it shouldn't block this PR

aristocratos/btop#774

[dm17]

I'm not seeing how to get the GPU to display. I've AMDGPUs

[Calandracas606]

@dm17

I'm not seeing how to get the GPU to display. I've AMDGPUs

btop needs rocm-smi-lib #48744 to display amdgpu details

however, btop also appears bugged, and fails to display without a patch: aristocratos/btop#774

only with patched btop, and rocm-smi-lib will the gpu show: