Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwacom: add missing dep for -devel subpkg #48205

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Conversation

chrysos349
Copy link
Contributor

libwacom-devel-2.9.0 requires libevdev-devel as a dependency.

mutter which depends on libwacom-devel fails to build and spits out this error:

meson.build:284:17: ERROR: Dependency lookup for libwacom with method 'pkgconfig' failed: Could not generate cflags for libwacom:
Package libevdev was not found in the pkg-config search path.
Perhaps you should add the directory containing `libevdev.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libevdev', required by 'libwacom', not found

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

@sgn
Copy link
Member

sgn commented Jan 14, 2024

This is wrong, libwacom only Requires.private: gudev-1.0, glib-2.0, libevdev. Hence, no.

Comment on lines +29 to +30
depends="libgudev-devel ${sourcepkg}>=${version}_${revision}
libevdev-devel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends="libgudev-devel ${sourcepkg}>=${version}_${revision}
libevdev-devel"
depends="${sourcepkg}>=${version}_${revision}"

libwacom only Requires.private: gudev-1.0, glib-2.0, libevdev hence, it shouldn't depend on libgudev-devel either.

@sgn
Copy link
Member

sgn commented Jan 14, 2024

Hm, may be I was wrong, Requires.private: gudev-1.0, glib-2.0, libevdev cause pkg-config --cflags failure if it's not exists.

I think in libwacom case, it should be Libs.private instead.

@sgn sgn merged commit 8fde72b into void-linux:master Jan 14, 2024
8 checks passed
@chrysos349 chrysos349 deleted the libwacom branch January 17, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants