Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[squashfs-tools]: do not create symlinks manually #48214

Closed
wants to merge 1 commit into from
Closed

[squashfs-tools]: do not create symlinks manually #48214

wants to merge 1 commit into from

Conversation

firasuke
Copy link

These symlinks are created automatically upon installation.

Testing the changes

  • I tested the changes in this PR: NO

These symlinks are created automatically upon installation.
@classabbyamp
Copy link
Member

what do you mean by "created automatically upon installation"?

@firasuke
Copy link
Author

make install should handle both binary installation and symlink creation, yet it seems you are doing manual installation.

@classabbyamp
Copy link
Member

if that's the case, then your patch is wrong: you're just removing the symlinks from the package altogether

@classabbyamp
Copy link
Member

d29d187 does it the right way

@firasuke firasuke deleted the patch-1 branch January 15, 2024 06:27
@firasuke
Copy link
Author

if that's the case, then your patch is wrong: you're just removing the symlinks from the package altogether

Ah I see, you were not using make install in the first place, and the manual binary installation should also be removed, makes sense.

Calandracas606 pushed a commit to Calandracas606/void-packages that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants