Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incus: update to 04.0_1 #48357

Closed
wants to merge 1 commit into from
Closed

Conversation

sbromberger
Copy link
Contributor

Fixes #48356.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, Linux elemental 6.6.11_1 #1 SMP PREEMPT_DYNAMIC Sat Jan 13 23:28:15 UTC 2024 x86_64 GNU/Linux

@sbromberger sbromberger changed the title Incus: update run - fixes #48356 Incus: update to 04.0_1 Jan 24, 2024
@dkwo
Copy link
Contributor

dkwo commented Jan 24, 2024

I was explicitly asked to remove that hack, cc @CameronNemo
Btw, commit msg should be like incus: update service and it should also bump revision.

@dkwo
Copy link
Contributor

dkwo commented Jan 24, 2024

Remove the cgroup changes. The user can fix the cgroups if necessary, but usually they should be using unified (i.e. cgroup2 only), and this would just be wrong in that case.

@sbromberger
Copy link
Contributor Author

I think this breaks all systemd-based guests though.

@CameronNemo
Copy link
Contributor

@sbromberger You can put it in your rc.local if it is necessary. It doesn't make much sense to have it in each individual container service. Alternatively I am pretty sure you don't need (and don't want!) this if you are using a pure cgroup2 setup. Just set CGROUP_MODE in rc.conf to unified instead of hybrid.

@sbromberger
Copy link
Contributor Author

@CameronNemo - enabling unified worked (I had hybrid commented out but that apparently didn't do it). Thank you. I'll close this out.

@sbromberger sbromberger deleted the patch-4 branch January 24, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incus images based on Ubuntu fail to start
3 participants