Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lf: build with cgo=0, run checks #48373

Closed
wants to merge 1 commit into from
Closed

lf: build with cgo=0, run checks #48373

wants to merge 1 commit into from

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented Jan 25, 2024

build static as suggested by upstream, run checks. cc maintainer @TeddyDD

  • I tested the changes in this PR: yes
  • I built this PR locally for my native architecture, (x86_64)
  • I built this PR locally for these architectures (cross aarch64-musl)

@TeddyDD
Copy link
Contributor

TeddyDD commented Jan 26, 2024

What's the added value of building this statically for system-wide installation? From what I see, Void defaults to CGO_ENABLED=1

@dkwo
Copy link
Contributor Author

dkwo commented Jan 30, 2024

That's what upstream does and suggests. What's the disadvantage?

@TeddyDD
Copy link
Contributor

TeddyDD commented Jan 31, 2024

That's what upstream does and suggests

It's not a strong suggestion, just copy-paste instruction for people who want to build it from source.
Half of programs written in Go suggest you should do static build so you can copy binary around.

For whatever reason, Void doesn't do this, and I fell like exceptions shoud be justified.

@dkwo
Copy link
Contributor Author

dkwo commented Jan 31, 2024

Fair enough.

@dkwo dkwo closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants