Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsettings-desktop-schemas: missing font dependency #48382

Closed
wants to merge 1 commit into from
Closed

gsettings-desktop-schemas: missing font dependency #48382

wants to merge 1 commit into from

Conversation

c0m4r
Copy link
Contributor

@c0m4r c0m4r commented Jan 26, 2024

org.gnome.desktop.interface monospace-font-name default is 'Source Code Pro 10', which is missing
adding this dependency will fix default configuration with dependent packages like tilix, terminator and probably others

Testing the changes

  • I tested the changes in this PR: YES

@ahesford
Copy link
Member

The schema also references Cantarell, but GTK applications with client-side decorations still seem to function with an alternative font.

It would seem better to have the default schema reference generic font aliases rather than specific fonts.

@c0m4r
Copy link
Contributor Author

c0m4r commented Jan 31, 2024

The schema also references Cantarell, but GTK applications with client-side decorations still seem to function with an alternative font.

That's correct, however that's not the case in terminal emulators. You either need to provide the correct font or change the configuration pointing to the generic Monospace font (Debian does that). The idea is so it just works by default, without such changes.

It would seem better to have the default schema reference generic font aliases rather than specific fonts.

It depends. I compared solutions used by other distros and I found this font as a dep less invasive and problematic. It's widely used and you don't need to modify schemas, nor configuration. By changing the default schemas there's no guarantee that it's not already overwritten by the local or user configuration, still pointing to the missing font. Moreover, this way we use native, consistent fonts. So in terms of user experience I'd vote for adding missing font the way that Arch does that, rather that the overwriting schemas.

And even Debian's gsettings-desktop-schemas.gsettings-override mentions:

# Adobe Source Code Pro is not in Debian yet
# See https://bugs.debian.org/736681 and https://bugs.debian.org/762252
[org.gnome.desktop.interface]
monospace-font-name = 'Monospace 11'

so if we have the font in the repo, I think it's worth using it

@ahesford
Copy link
Member

My argument is that upstream should use a generic label, not necessarily that we should patch the schema. The reference to Cantarell may be considered a special case because the font is maintained by the GNOME project as the official UI font, whereas Source Code Pro is an external font whose associated use in terminal emulators is likely to incite a lot of passionate opinion.

@c0m4r
Copy link
Contributor Author

c0m4r commented Jan 31, 2024

My argument is that upstream should use a generic label, not necessarily that we should patch the schema.

Agreed. Yet, I don't believe we're gonna influence such change.

whereas Source Code Pro is an external font whose associated use in terminal emulators is likely to incite a lot of passionate opinion.

We'd better not get into THESE discussions ;) Though it's only a font, not the init system :)
But if it were to turn into such a big deal, the compromise solution is to make a schema patch or an override.
Just let me know, if there's no go for a font dep I'm gonna try to prepare an alternative solution.

@c0m4r c0m4r closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants