lcms2: disable plugins for now #48438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's is fine at is. Not sure if it would work when we split the plugins into subpackages? |
imo, probably best to wait for upstream's response regarding soversions before packaging them. (also the plugins get added to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Plugins were enabled in b9b9189
The plugins get linked to applications (
dlopen()is not used). However they were not added tocommon/shlibscausing packages to link against the plugins but error due to the shlibs not having an associated package.The plugins don't have a soversion, however, as this is inconsistent between configuring with autoconf vs meson, I assume this is a mistake. As such, disable until the following is addressed: mm2/Little-CMS#432
Fixes building gimp, Krita, libraw, etc.
cc: @sgn