Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: uutils-0.0.24 #48534

Closed
wants to merge 1 commit into from
Closed

Conversation

caughtquick
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64 glibc)

This PR closes #47445

@classabbyamp classabbyamp added the new-package This PR adds a new package label Feb 5, 2024
@caughtquick
Copy link
Contributor Author

This built fine on my x86_64 glibc PC, not sure why it's not building now

@oreo639
Copy link
Member

oreo639 commented Feb 5, 2024

Those are test failures. Run them locally and see if they succeed.
Sometimes test failures are because of bugs in the application other times, test failures are because some functions aren't supported when run in the container. Some tests rely on other software running before the tests are started, for example, some packages have tests that rely on having a desktop running.

The way to resolve the test failure depends on why it is failing.

@caughtquick
Copy link
Contributor Author

caughtquick commented Feb 5, 2024

In regards to x86_64-glibc, the package built fine, should I be checking x86_64-musl and i686-glibc locally (crossbuilds?)?

@oreo639
Copy link
Member

oreo639 commented Feb 5, 2024

In regards to x86_64-glibc, the package built fine

You need to do ./xbps-src pkg -Q uutils or ./xbps-src check uutils in order to run the tests.

The test failures do appear to be related to the chroot type and running locally (defaults to uunshare) does give completely different failures to CI (uses ethereal).

It may require make_check=no.

should I be checking x86_64-musl and i686-glibc locally (crossbuilds?)?

Those are not cross builds, they are native builds. (-a i686 is cross and -A i686 is native)
You can't run tests when cross compiling.

@ahesford
Copy link
Member

ahesford commented Feb 5, 2024

This package is misnamed. Normally it should be coreutils, which obviously conflicts, so maybe uutils-coreutils is a better choice.

I find the documentation very opaque, either because it's missing critical information or because I'm looking for critical information on a phone. The documentation I did find says that "uutils includes a multi-call binary from which the utils can be invoked", but does not say that uutils is comprised of a multi-call binary. This makes it sound like the multi-call binary is an optional component of a package that also provides individual commands.

Please confirm that the single executable installed by this package is the multi-call executable and can (should) be run similarly to busybox. In particular, I want to ensure that running /usr/bin/coreutils won't "helpfully" do something destructive like unpack a bunch of commands or make a bunch of symlinks that would interfere with the system coreutils package.

@caughtquick
Copy link
Contributor Author

Running 'coreutils' does not do anything destructive, it just prompts you to run the command you want, for example 'coreutils ls' or 'coreutils bat'. It does not appear to conflict with the GNU coreutils installed by default on the system. In regards to the name change, I'll make that now.

Copy link

github-actions bot commented May 6, 2024

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 6, 2024
@github-actions github-actions bot closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: uutils
4 participants