Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: eduke32-20240316.r10564 #48586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New package: eduke32-20240316.r10564 #48586

wants to merge 1 commit into from

Conversation

MIvanchev
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (GLIBC-X86_64)

classabbyamp
classabbyamp reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@classabbyamp classabbyamp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not be vendoring icons and desktop files in the srcpkgs tree. they should come from upstream

@classabbyamp classabbyamp added the new-package This PR adds a new package label Feb 7, 2024
@MIvanchev
Copy link
Contributor Author

MIvanchev commented Feb 7, 2024 •
edited

@classabbyamp The icons are from upstream, just dumped. There is no desktop file upstream sadly, what should I do?

Edit: I removed them as discussed.

@MIvanchev MIvanchev force-pushed the eduke32 branch 5 times, most recently from a03bfb9 to 119b4ab Compare February 7, 2024 18:38
@MIvanchev MIvanchev force-pushed the eduke32 branch 3 times, most recently from dfe07a8 to 0de729f Compare February 7, 2024 19:29
@MIvanchev MIvanchev changed the title New package: eduke32-20231224.10548 New package: eduke32-20231224.r10548 Feb 7, 2024
@MIvanchev MIvanchev force-pushed the eduke32 branch 2 times, most recently from 8dc53c8 to 696d951 Compare March 27, 2024 16:10
@MIvanchev MIvanchev changed the title New package: eduke32-20231224.r10548 New package: eduke32-20240316.r10564 Mar 27, 2024
@MIvanchev MIvanchev force-pushed the eduke32 branch 4 times, most recently from 5c066cb to 038c5aa Compare April 9, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocimier Chocimier Chocimier left review comments

@classabbyamp classabbyamp classabbyamp left review comments

Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MIvanchev @Chocimier @classabbyamp