Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: llvm18 #48661

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Calandracas606
Copy link

@Calandracas606 Calandracas606 commented Feb 11, 2024

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-musl
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl
    • i686
    • aarch64-musl (cross)
    • armv7l (cross)
    • armv6l-musl (cross)

[ci skip]

Comment on lines 358 to 359
vmove usr/bin/hmaptool
vmove usr/bin/git-clang-format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmaptool goes to -tools-extra, git-clang-format goes to same packages with clang-format.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think hmaptool should go to clang

build_wrksrc=llvm
build_style=cmake
_ext_suffix=".cpython-${py3_ver/./}-linux-${XBPS_TARGET_LIBC/glibc/gnu}.so"
pycompile_dirs="usr/share/scan-view"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pycompile_dirs goes to clang-analyzer

@zlice
Copy link
Contributor

zlice commented Apr 6, 2024

I saw this while checking on where zig was at. I have intel opencl that was working with llvm15 but from intel's open issues 16, and I assume 17, will be in the air for a while. With 18 being updated, should I just mark intel opencl as a lost cause? I don't know that they will ever be "caught up" and things will be able to compile with void's versions.

@Calandracas606
Copy link
Author

I saw this while checking on where zig was at. I have intel opencl that was working with llvm15 but from intel's open issues 16, and I assume 17, will be in the air for a while. With 18 being updated, should I just mark intel opencl as a lost cause? I don't know that they will ever be "caught up" and things will be able to compile with void's versions.

llvm15 won't be going anywhere. the libraries (libllvm15, libclang15, etc) will likely stick around as long as they are needed, llvm12 is still packaged for example

@zlice
Copy link
Contributor

zlice commented Apr 6, 2024

I'll try again with 15 sometime, I thought the -devel package was needed and that seems to be gone.

@zlice
Copy link
Contributor

zlice commented Apr 6, 2024

So it may not be llvm/clang needed devel, but SPIRV devel packages. I assume that conflicts between versions which is why only the latest (17) is in the repos?

@leahneukirchen
Copy link
Member

Please add libomp-devel to the dependency hull of llvm18-devel, this breaks cmake often.

@Calandracas606
Copy link
Author

Please add libomp-devel to the dependency hull of llvm18-devel, this breaks cmake often.

that fix should already be part of this PR

@Calandracas606
Copy link
Author

template seems mostly fine.

only remaining issue is that compiler-rt17 fails to build on armv*-musl due to failing a static assertion. (works fine with compiler-rt18)

seems to only occur when the only runtime built is compiler-rt. if libcxx and unwinder are built alongside it, the error does not occur.

@Calandracas606
Copy link
Author

So it may not be llvm/clang needed devel, but SPIRV devel packages. I assume that conflicts between versions which is why only the latest (17) is in the repos?

@zlice at one point I did have a working intel level-zero and intel opencl template with llvm15, but never got around to figuring out how to patch it for musl

it probably makes sense to version SPIRV, there's no reason why libLLVMSPRIVLib.so.18 and libLLVMSPIRVLib.so.17 can't co-exist.

@Calandracas606
Copy link
Author

I think the PR is nearly ready to go, just doing some final build testing

@Calandracas606 Calandracas606 marked this pull request as ready for review April 18, 2024 21:52
@Calandracas606
Copy link
Author

PR is ready for merge.

Should be relatively safe, it only adds llvm18, but doesn't actually build anything against it. Having it available ahead of time will be useful for when rust and chromium are eventually dependent on it

@Calandracas606
Copy link
Author

rebased the branch.

A review would be really appreciated.

I've been running this PR for months now, and I'm pretty sure I've fixed all the quirks, and that this should be safe to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants