-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: llvm18 #48661
New package: llvm18 #48661
Conversation
3ad71ee
to
5edd2bd
Compare
d0bf53c
to
b6ca7da
Compare
b6ca7da
to
7ea6877
Compare
srcpkgs/llvm18/template
Outdated
vmove usr/bin/hmaptool | ||
vmove usr/bin/git-clang-format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmaptool
goes to -tools-extra
, git-clang-format
goes to same packages with clang-format
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I think hmaptool
should go to clang
srcpkgs/llvm18/template
Outdated
build_wrksrc=llvm | ||
build_style=cmake | ||
_ext_suffix=".cpython-${py3_ver/./}-linux-${XBPS_TARGET_LIBC/glibc/gnu}.so" | ||
pycompile_dirs="usr/share/scan-view" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pycompile_dirs
goes to clang-analyzer
58f62b8
to
231ecfd
Compare
31e490d
to
ae3f22f
Compare
I saw this while checking on where zig was at. I have intel opencl that was working with llvm15 but from intel's open issues 16, and I assume 17, will be in the air for a while. With 18 being updated, should I just mark intel opencl as a lost cause? I don't know that they will ever be "caught up" and things will be able to compile with void's versions. |
llvm15 won't be going anywhere. the libraries (libllvm15, libclang15, etc) will likely stick around as long as they are needed, llvm12 is still packaged for example |
I'll try again with 15 sometime, I thought the |
So it may not be llvm/clang needed devel, but SPIRV devel packages. I assume that conflicts between versions which is why only the latest (17) is in the repos? |
Please add libomp-devel to the dependency hull of llvm18-devel, this breaks cmake often. |
that fix should already be part of this PR |
template seems mostly fine. only remaining issue is that compiler-rt17 fails to build on seems to only occur when the only runtime built is compiler-rt. if libcxx and unwinder are built alongside it, the error does not occur. |
@zlice at one point I did have a working intel level-zero and intel opencl template with llvm15, but never got around to figuring out how to patch it for musl it probably makes sense to version SPIRV, there's no reason why libLLVMSPRIVLib.so.18 and libLLVMSPIRVLib.so.17 can't co-exist. |
068465b
to
b11889a
Compare
I think the PR is nearly ready to go, just doing some final build testing |
70a0eb3
to
6e79b4f
Compare
PR is ready for merge. Should be relatively safe, it only adds llvm18, but doesn't actually build anything against it. Having it available ahead of time will be useful for when rust and chromium are eventually dependent on it |
f021e1f
to
238564a
Compare
240326c
to
b561d1a
Compare
rebased the branch. A review would be really appreciated. I've been running this PR for months now, and I'm pretty sure I've fixed all the quirks, and that this should be safe to merge |
agree it would be appreciated to have this reviewed! |
373cfc9
to
60cdca4
Compare
thanks for updating llvm to v18! why does the shared lib |
because libclang is where the magic happens. libclang can be thought of as a sort of "embedded compiler", the main "clang" binary mostly just calls libclang since libclang does the actual compiling, it needs the headers. This means that other programs can use clang by linking libclang, rather than by executing the clang binary. For example, this is done by Mesa. |
pushed a small fix for when natively compiling on aarch64 |
Testing the changes
New package
Local build testing
[ci skip]