Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: alexvsbus #48682

Closed
wants to merge 9 commits into from
Closed

New package: alexvsbus #48682

wants to merge 9 commits into from

Conversation

M374LX
Copy link

@M374LX M374LX commented Feb 13, 2024

Closes #48647

Testing the changes

  • I tested the changes in this PR: yes

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

More information

Tested and confirmed to run on my x86_64-glibc host system and also on x86_64 (both glibc and musl) virtual machines containing a newly installed Void system and an X server, even without a window manager.

The game can run without alsa-lib, albeit without audio.

@classabbyamp classabbyamp added the new-package This PR adds a new package label Feb 13, 2024
@Eloitor
Copy link
Contributor

Eloitor commented Feb 13, 2024

You can try adding raylib: https://github.com/void-linux/void-packages/pull/41218/files
(do it in a separate commit on the same Pull request)

@M374LX
Copy link
Author

M374LX commented Feb 13, 2024

The game's sources bundle raylib already.

It looks like xbps-src is overriding the Makefile's CFLAGS. If so, what should I do when the Makefile contains its own CFLAGS?

Update: Adding custom do_build() and do_install() functions seems to fix the problems. I am now able to build the package from xbps-src.

@Eloitor
Copy link
Contributor

Eloitor commented Feb 13, 2024

I think you should put whatever you need into CFLAGS, look at some examples https://github.com/search?q=repo%3Avoid-linux%2Fvoid-packages%20CFLAGS%3D&type=code

@M374LX
Copy link
Author

M374LX commented Feb 13, 2024

@Eloitor Creating custom do_build() and do_install() functions instead of relying on build_style=gnu-makefile seems to have finally fixed the problems.

@M374LX M374LX marked this pull request as ready for review February 18, 2024 19:21
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 19, 2024
@github-actions github-actions bot closed this Jun 2, 2024
@M374LX
Copy link
Author

M374LX commented Jun 5, 2024

It looks like this PR has become staled and closed automatically.

Is it a better idea to reopen this one or to open a new one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: alexvsbus
3 participants