Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: lua-lanes-3.16.1 #48702

Closed
wants to merge 2 commits into from

Conversation

Calandracas606
Copy link

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, x86_64-musl
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl (cross)
    • armv7l (cross)
    • armv6l-musl (cross)

Copy link
Author

@Calandracas606 Calandracas606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream says that it should support Lua 5.1 - 5.4, however the build system is only setup to detect Lua5.1, and LuaJIT

Comment on lines +9 to +10
- CFLAGS=-Wall -Werror $(OPT_FLAGS) $(LUA_FLAGS)
+ CFLAGS+=$(LUA_FLAGS)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

respect our cflags

@@ -46,6 +46,7 @@ desc_option_ldns="Enable support for LDNS DNSSEC library"
desc_option_libao="Enable support for libao sound library"
desc_option_libedit="Enable support for NetBSD's libedit"
desc_option_lua="Enable support for Lua"
desc_option_luajit="Enable support for LuaJIT"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling LuaJIT is common option for several Lua packages

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 14, 2024
@github-actions github-actions bot closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants