telegram-desktop: remove unused makedeps #48924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtk+3 used to be needed for the gtk filechooser, but doesn't appear to be used anymore. webkit2gtk is not needed at build time and is dlopen()'d at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
@Johnnynator webkit2gtk currently is not a rundep for
telegram-desktoppackage.Would you like it to stay that way (since there are multiple versions of webkit2gtk and if you don't have it installed telegram-desktop displays a message telling you to install it), otherwise I can add either libwebkitgtk60 or libwebkit2gtk41, either are supported: https://github.com/desktop-app/lib_webview/blob/4fce8b1971721da739619acf36da0fe79d614a23/webview/platform/linux/webview_linux_webkitgtk_library.cpp#L14-L16