Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libextractor: update to 1.13. #48941

Closed
wants to merge 1 commit into from

Conversation

yoshiyoshyosh
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl

merge before #43761

no longer needs ffmpeg libraries, replaced with gstreamer. extract throws an error with exiv2 plugin when trying to extract stuff that's not an image, which is apparently intentional (line 605 of exiv2_extractor.cc)

@sgn
Copy link
Member

sgn commented Feb 26, 2024

The exception exists in current version. But it's bad!

@yoshiyoshyosh
Copy link
Contributor Author

yoshiyoshyosh commented Feb 26, 2024

yeah, I think it's a little silly how they made the exiv2 plugin... throw an exception instead of simply not run when it runs on a file that can't be loaded by exiv2. it can be worked around in extract by either not using -i and ignoring the error that pops up on its thread or using -n -l <plugins_you_need> for the specific plugins one needs for a file. in any case, it's an intentional design decision, but is it our responsibility to patch it out? I'm not sure

@sgn sgn closed this in 5786866 Mar 2, 2024
@yoshiyoshyosh yoshiyoshyosh deleted the libextractor branch May 25, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants